Pre-reset changes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemoya
approved these changes
Mar 20, 2019
rtalvarez
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
lgtm - it seems like users will no longer be able to further style our components, since the className prop is being left out. im ok with this since it makes it a bit harder for people to override our stuff. while working in the sample app i had the need to style plab components mostly to add margins, so we'll need to take care of that further down the road
| <RawCheckbox {...props} forwardedRef={ref} /> | ||
| )); | ||
|
|
||
| export const Checkbox = hoistNonReactStatics(CheckboxWithForwardedRef, RawCheckbox); |
There was a problem hiding this comment.
🍹 might be worthwhile to drop a comment saying statics are not passed automatically, maybe link to https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over ??
MariaJose
added a commit
to MariaJose/big-design
that referenced
this pull request
Sep 16, 2021
* feat(component): create gucci box * feat(component): apply suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All will be re-reviewed on project-reset
Important/Meta changes:
All changes:
fix(plab): tests now run with lerna setup
chore(all): bump dependencies
refactor(plab): remove deprecated method from polished
chore(storybook): update how we use a11y and viewport
fix(storybook): fix a11y violations
fix(plab): fix a11y violations
fix(plab): icon generation props
test(plab): basic button render tests
feat(plab): forwardRef for Form component
feat(plab): forwardedRef Input + remove unsed types
feat(plab): forwardRef for Checkbox
feat(plab): forwardedRef for Radio component
chore(plab): add peerDependencies
ci(all): bump yarn in travis
chore(storybook): change directory structure
test(plab): use react-testing-library
test(plab): checkbox + radio basic specs
test(plab): add more tests
test(plab): modal + panel tests
feat(plab): lock down styles
fix(storybook): prettier script
fix(plab): point to correct typings